Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace HTTP client on TestClient from requests to httpx #1376

Merged
merged 25 commits into from Sep 6, 2022
Merged
Show file tree
Hide file tree
Changes from 7 commits
Commits
Show all changes
25 commits
Select commit Hold shift + click to select a range
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
3 changes: 2 additions & 1 deletion setup.py
Expand Up @@ -48,7 +48,8 @@ def get_long_description():
"jinja2",
"python-multipart",
"pyyaml",
"requests",
# "httpx>=0.20.0"
"httpx @ git+https://github.com/encode/httpx.git@master",
Copy link
Sponsor Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Until next httpx release. This is a blocker.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could httpx cut a release? This is going to cause issues for anyone that depends on httpx right? I realize you can probably just not install the "full" extra, but this still breaks things for those that are already doing it / it's a bit unergonomic and confusing.

]
},
classifiers=[
Expand Down
1 change: 1 addition & 0 deletions starlette/_compat.py
Expand Up @@ -23,6 +23,7 @@ def md5_hexdigest(
data, usedforsecurity=usedforsecurity
).hexdigest()


except TypeError: # pragma: no cover

def md5_hexdigest(data: bytes, *, usedforsecurity: bool = True) -> str:
Expand Down