New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace HTTP client on TestClient from requests
to httpx
#1376
Merged
Merged
Changes from 7 commits
Commits
Show all changes
25 commits
Select commit
Hold shift + click to select a range
0eebb70
Replace HTTP client on TestClient from requests to httpx
Kludex 067e8e6
Fix mypy issues
faf26d9
Remove asgiref
Kludex 344660d
add pragmas
Kludex da47981
Merge branch 'master' into httpx-based-testclient
Kludex 4fd1e2d
merge master
Kludex f9dcb68
Tests passing
Kludex 440b78a
black
Kludex 1ed683c
Fix documentation
Kludex 342b549
Add compat
Kludex b32744b
Add `data=...` compat
Kludex 3c7e0b1
Merge branch 'master' into httpx-based-testclient
Kludex 3043e99
Merge branch 'master' into httpx-based-testclient
Kludex ae693da
Add raw path instead of path.encode
Kludex 96fd95f
Merge branch 'master' into httpx-based-testclient
adriangb 8869578
rebase
Kludex 483fa22
Merge branch 'httpx-based-testclient' of github.com:Kludex/starlette …
Kludex ec870eb
Merge branch 'master' into httpx-based-testclient
Kludex fcb003b
rebase and bump httpx
Kludex 38d8204
rebase
Kludex 3050e9e
Merge branch 'master' into httpx-based-testclient
Kludex 0d7af25
Update README.md
Kludex 6fd4f2c
Merge branch 'master' into httpx-based-testclient
Kludex 92b1514
Update pyproject.toml
Kludex d798ae9
Merge branch 'master' into httpx-based-testclient
Kludex File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Until next httpx release. This is a blocker.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could httpx cut a release? This is going to cause issues for anyone that depends on httpx right? I realize you can probably just not install the "full" extra, but this still breaks things for those that are already doing it / it's a bit unergonomic and confusing.