Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: pass usedforsecurity to hashlib.md5 to fix error on FIPS-enabled systems #1366

Merged
merged 15 commits into from Dec 17, 2021
Merged

fix: pass usedforsecurity to hashlib.md5 to fix error on FIPS-enabled systems #1366

merged 15 commits into from Dec 17, 2021

Conversation

adriangb
Copy link
Member

Closes #1365

adriangb
adriangb commented Dec 15, 2021
View reviewed changes
Copy link
Member Author

@adriangb adriangb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One thing I wasn't sure about: do we want a test that monkey patches hashlib to verify that we are passing usedforsecurity=False? Seems like overkill to me

starlette/_crypto.py Outdated Show resolved Hide resolved
starlette/_crypto.py Outdated Show resolved Hide resolved
starlette/responses.py Show resolved Hide resolved
starlette/_crypto.py Outdated Show resolved Hide resolved
starlette/responses.py Outdated Show resolved Hide resolved
tomchristie
tomchristie reviewed Dec 16, 2021
View reviewed changes
starlette/_compat.py Outdated Show resolved Hide resolved
@tomchristie
Copy link
Member

@adriangb Fantastic, thanks! I've invited you as a maintainer, so that you can merge this PR yourself.
You'll then be able to merge or approve other pull requests too. 👍

@adriangb adriangb merged commit 0aef172 into encode:master Dec 17, 2021
@adriangb adriangb deleted the 1365-use-usedforsecurity-parameter branch December 17, 2021 12:37
@adriangb
Copy link
Member Author

Worked perfectly, thank you Tom

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kludex Kludex Kludex left review comments

@vakwetu vakwetu vakwetu left review comments

@tomchristie tomchristie tomchristie approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ETag checksum fails on FIPS-enabled systems when using MD5
4 participants
@adriangb @tomchristie @Kludex @vakwetu