Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Display missing route details. #1363

Merged
merged 9 commits into from Feb 14, 2022
Merged

Display missing route details. #1363

merged 9 commits into from Feb 14, 2022

Conversation

alex-oleshkevich
Copy link
Member

This PR improves error reporting for NoMatchFound exception.
image

@Kludex
Copy link
Sponsor Member

Kludex commented Dec 14, 2021

For the record, this is what we have before this PR:

image

Kludex
Kludex reviewed Dec 14, 2021
View reviewed changes
starlette/routing.py Outdated Show resolved Hide resolved
@Kludex Kludex mentioned this pull request Dec 20, 2021
Merged
8 tasks
@adriangb adriangb added the feature New feature or request label Feb 2, 2022
@tomchristie
Copy link
Member

This is a clear win, yup!

Do we think we need to be concerned about folks raising NoMatchFound() directly in their own codebases, and continue to support but deprecate that case? (I don't think we document it anywhere, so arguably it's private-enough-ish not to be too concerned about this?)

@tomchristie tomchristie merged commit 93ad0b9 into encode:master Feb 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kludex Kludex Kludex left review comments

@tomchristie tomchristie tomchristie approved these changes

Assignees
No one assigned
Labels
feature New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@alex-oleshkevich @Kludex @tomchristie @adriangb