Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change default chunk size from 4Kb to 64Kb #1345

Merged
merged 3 commits into from Dec 5, 2021

Conversation

Kludex
Copy link
Sponsor Member

@Kludex Kludex commented Nov 27, 2021

@tomchristie On that issue, you said that "httpx uses 64k read size", but I couldn't find that. Do you mind pointing me out what did you mean?

@dalf
Copy link

dalf commented Dec 3, 2021

starlette/responses.py Outdated Show resolved Hide resolved
@Kludex
Copy link
Sponsor Member Author

Kludex commented Dec 3, 2021

Thanks @dalf ! Much appreciated! 🎉

Copy link
Member

@florimondmanca florimondmanca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good! That's quite a similar change to the one we made in HTTPX indeed, and for the same reason (improving transfer speed by using larger chunks).

@Kludex
Copy link
Sponsor Member Author

Kludex commented Dec 5, 2021

Thanks @florimondmanca ! 🎉

@Kludex Kludex merged commit 1d1dcba into encode:master Dec 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make FileResponse.chunk_size variable
3 participants