Ignore BrokenResourceError in BaseHTTPMiddleware #1318
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brakhane
force-pushed
the
fix-broken-resource-error
branch
4 times, most recently
from
41672b2
to
b1b384e
Compare
ASGI specifies that send is a no-op when the connection is closed. HTTPMiddleware uses anyio streams which will raise an exception when the connection is closed prematurely. So we need to ignore the exception in our send function. Fixes encode#1284
brakhane
force-pushed
the
fix-broken-resource-error
branch
from
b1b384e
to
a07b299
Compare
|
The failing test seems like a random segmentation fault and I don't think my changes are responsible. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ASGI specifies that send is a no-op when the connection is closed.
HTTPMiddleware uses anyio streams which will raise
an exception when the connection is closed prematurely.
So we need to ignore the exception in our send function.
Fixes #1284