Update the Jinja2Templates() constructor to allow PathLike #1292
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kludex
requested changes
Sep 26, 2021
There was a problem hiding this comment.
@tonybaloney Thanks for the PR! 🎉
I also prefer to import each type from typing, but I would like to maintain consistency between modules. 😗
Would you mind checking my suggestions? It also solves the CI.
Co-authored-by: Marcelo Trylesinski <marcelotryle@gmail.com>
Co-authored-by: Marcelo Trylesinski <marcelotryle@gmail.com>
Co-authored-by: Marcelo Trylesinski <marcelotryle@gmail.com>
|
Done! Thanks |
Kludex
requested changes
Sep 26, 2021
Kludex
approved these changes
Sep 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The directory argument for
Jinja2Templatesis annotated as astr, which means a type checker fails if you pass apathlib.Path, but Jinja2 acceptsPathLike[str](either a path string or a Path) for environment creation.This PR updates the type annotation to allow both cases.