Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

change-ImmutableMultiDict-get-list-typing #1235

Merged
merged 5 commits into from Sep 25, 2021
Merged

change-ImmutableMultiDict-get-list-typing #1235

merged 5 commits into from Sep 25, 2021

Conversation

aminalaee
Copy link
Member

@aminalaee aminalaee commented Jul 4, 2021 •
edited

Fixes #994

ImmutableMultiDict get_list method should return List[Any]

Kludex
Kludex approved these changes Sep 25, 2021
View reviewed changes
Copy link
Sponsor Member

@Kludex Kludex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Thanks @aminalaee ! 🎉

@Kludex Kludex merged commit 134eb0b into encode:master Sep 25, 2021
@aminalaee aminalaee deleted the change-ImmutableMultiDict-get-list-typing branch September 26, 2021 05:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kludex Kludex Kludex approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ImmutableMultiDict returns a List[Any] instead of a List[str]
2 participants
@aminalaee @Kludex