Send lifespan.shutdown.failed event on lifespan shutdown error #1205
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JayH5
commented
Jun 19, 2021
|
|
||
| async def _lifespan_iter( | ||
| self, gen: typing.AsyncGenerator, receive: Receive, send: Send | ||
| ) -> None: | ||
| try: |
There was a problem hiding this comment.
There was a problem hiding this comment.
I think just making lifespan context an asynccontextmanager factory makes all this easier
|
Superseded by #1227 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1138
We supported
lifespan.startup.failedbut notlifespan.shutdown.failedfor some reason. These were added in the Lifespan 2.0 ASGI spec.Previously, we used single-iteration for-loops to communicate with the lifespan generator. This changes to an explicit
try/except StopAsyncIteration, closer to what pytest/AnyIO do when calling test fixtures.Added additional tests for the incorrect number of yields. Previously we just had an
asserton a boolean flag, but now we explicitly raise aRuntimeError(again, similar to pytest which raises this error type in a similar situation).