New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
馃敟 Remove GraphQL support #1198
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please fix the conflicts
325fdce
to
ad29baa
Compare
@auvipy took me some time, but here you have 馃槄 |
I've opened a PR on Strawberry to add an integration page with Starlette: https://strawberry.rocks/docs/integrations/starlette It was promptly accepted. 馃帀 Then, I've updated the documentation on the I'd like further approval, and I'm also not in a hurry to get this merged. :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some suggestions for the docs but 馃殌
Co-authored-by: Jamie Hewland <jhewland@gmail.com>
Co-authored-by: Jamie Hewland <jhewland@gmail.com>
@JayH5 Thanks for the suggestions! 馃槑 |
it's a cool idea. but why?) |
This PR removes GraphQL entirely. I've assumed that we don't need to document the removal, just the CHANGELOG is enough (correct me otherwise).
The idea is to merge this PR before 1.0. There's no hurry on this, once we fulfill the other requirements, we can come back to this PR.
Related issues