Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add HEAD to CORS ALL_METHODS list #1112

Merged
merged 4 commits into from Apr 6, 2021
Merged

Commits on Dec 11, 2020

  1. Add HEAD to CORS ALL_METHODS list

    The HEAD method is conspicuously absent from the allowed methods list when `allow_methods="*"` is
    used. This doesn't really affect CORS preflight requests, as HEAD requests aren't preflighted by the
    browser, but it does prevent the actual cross-origin HEAD response from being read by the calling
    app.
    [This can catch people off-guard.](https://discuss.encode.io/t/for-cors-middleware-why-is-head-not-included-in-all-methods/939)
    
    This simply adds HEAD to the `ALL_METHODS` list in the CORS middleware module and includes some
    additional tests to validate the new behavior.
    Josh Wilson committed Dec 11, 2020
    Copy the full SHA
    584c715 View commit details
    Browse the repository at this point in the history

Commits on Dec 17, 2020

  1. Update tests/middleware/test_cors.py to use more explicit status code…

    … check
    
    Co-authored-by: euri10 <euri10@users.noreply.github.com>
    jcwilson and euri10 committed Dec 17, 2020
    Copy the full SHA
    caf8f04 View commit details
    Browse the repository at this point in the history

Commits on Apr 3, 2021

  1. Copy the full SHA
    90a6ece View commit details
    Browse the repository at this point in the history

Commits on Apr 6, 2021

  1. Copy the full SHA
    3a7b354 View commit details
    Browse the repository at this point in the history