Fix #472 (AssertionError with middleware and TemplateResponse) #1071
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
moriyoshi
force-pushed
the
fix-472-assertion-error-template-response
branch
2 times, most recently
from
9396504
to
84c372e
Compare
|
The failing mypy checks are addressed in the following PRs: |
moriyoshi
force-pushed
the
fix-472-assertion-error-template-response
branch
from
84c372e
to
06020b9
Compare
moriyoshi
force-pushed
the
fix-472-assertion-error-template-response
branch
from
06020b9
to
9729f2f
Compare
|
Now that both PRs have been merged, anyone can have a look at this? |
|
Anyone? |
|
What's missing to this to be merged? |
|
@moriyoshi Can you update please? |
|
I'm closing this as it's an old PR, and the author is no longer interested in this content. Let's work on a fix/trial for #472 on another PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch fixes #472.