Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix high memory usage when using BaseHTTPMiddleware middleware classes and streaming responses #1018

Merged
merged 2 commits into from Aug 4, 2020
Merged

Fix high memory usage when using BaseHTTPMiddleware middleware classes and streaming responses #1018

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
040e460
BaseHTTPMiddleware add maxsize arg to Queue constructor
erewok Aug 3, 2020
41cf67c
Add type hint suggestion for asyncio.Queue
erewok Aug 3, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 2 additions & 2 deletions starlette/middleware/base.py
View file
Open in desktop
Expand Up @@ -3,7 +3,7 @@

from starlette.requests import Request
from starlette.responses import Response, StreamingResponse
from starlette.types import ASGIApp, Receive, Scope, Send
from starlette.types import ASGIApp, Message, Receive, Scope, Send

RequestResponseEndpoint = typing.Callable[[Request], typing.Awaitable[Response]]
DispatchFunction = typing.Callable[
Expand All @@ -27,7 +27,7 @@ async def __call__(self, scope: Scope, receive: Receive, send: Send) -> None:

async def call_next(self, request: Request) -> Response:
loop = asyncio.get_event_loop()
queue = asyncio.Queue() # type: asyncio.Queue
queue: "asyncio.Queue[typing.Optional[Message]]" = asyncio.Queue(maxsize=1)

scope = request.scope
receive = request.receive
Expand Down