Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add type: ignore for aiofiles to make mypy happier #1072

Merged
merged 2 commits into from Oct 14, 2020
Merged

Add type: ignore for aiofiles to make mypy happier #1072

merged 2 commits into from Oct 14, 2020

Conversation

moriyoshi
Copy link
Contributor

These should be a valid fix because the same has been applied to ujson already.

@moriyoshi moriyoshi mentioned this pull request Oct 12, 2020
Closed
@moriyoshi
Copy link
Contributor Author 

starlette/responses.py:315: error: "AsyncBufferedReader" has no attribute "__aenter__"
starlette/responses.py:315: error: "AsyncBufferedReader" has no attribute "__aexit__"

They are caused by wrong type definitions in typeshed that I already addressed in another PR.

@JayH5
Copy link
Member

JayH5 commented Oct 12, 2020

They are caused by wrong type definitions in typeshed that I already addressed in another PR.

Which PR is this?

@moriyoshi
Copy link
Contributor Author

moriyoshi commented Oct 12, 2020 •
edited

Which PR is this?

python/typeshed#4650

@witling witling mentioned this pull request Oct 13, 2020
Merged
@JayH5
Copy link
Member

JayH5 commented Oct 14, 2020

@moriyoshi thank you. Would you mind adding another ignore to starlette/responses.py:315 so that the CI can pass and we can merge this (ideally with a link to your typeshed PR or issue)?

@moriyoshi
Copy link
Contributor Author

Would you mind adding another ignore to starlette/responses.py:315 so that the CI can pass and we can merge this (ideally with a link to your typeshed PR or issue)?

Done.

@JayH5
Copy link
Member

JayH5 commented Oct 14, 2020

Great. Thank you!

@JayH5 JayH5 changed the title Add type: ignore to make mypy happier Add type: ignore for aiofiles to make mypy happier Oct 14, 2020
@JayH5 JayH5 merged commit 192ac4e into encode:master Oct 14, 2020
@moriyoshi moriyoshi deleted the fix-failing-tests branch October 15, 2020 02:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JayH5 JayH5 JayH5 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@moriyoshi @JayH5