add note on type ignore in templating.py (#1556)

* add note on type ignore * Update templating.py * Update templating.py * Update templating.py
encode · Mar 28, 2022 · eeb0457 · eeb0457
1 parent 710aa62
commit eeb0457
Showing 1 changed file with 4 additions and 1 deletion.
diff --git a/starlette/templating.py b/starlette/templating.py
@@ -8,7 +8,10 @@
 try:
     import jinja2
 
-    # @contextfunction renamed to @pass_context in Jinja 3.0, to be removed in 3.1
+    # @contextfunction was renamed to @pass_context in Jinja 3.0, and was removed in 3.1
+    # hence we try to get pass_context (most installs will be >=3.1)
+    # and fall back to contextfunction,
+    # adding a type ignore for mypy to let us access an attribute that may not exist
     if hasattr(jinja2, "pass_context"):
         pass_context = jinja2.pass_context
     else:  # pragma: nocover