Skip to content

Commit

Permalink
Test on Python 3.10 (#1201)
Browse files Browse the repository at this point in the history
  • Loading branch information
JayH5 committed Jun 19, 2021
1 parent a839d92 commit ab0fff9
Show file tree
Hide file tree
Showing 6 changed files with 17 additions and 6 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/test-suite.yml
Expand Up @@ -14,7 +14,7 @@ jobs:

strategy:
matrix:
python-version: ["3.6", "3.7", "3.8", "3.9"]
python-version: ["3.6", "3.7", "3.8", "3.9", "3.10.0-beta.3"]

steps:
- uses: "actions/checkout@v2"
Expand Down
7 changes: 4 additions & 3 deletions docs/graphql.md
Expand Up @@ -2,9 +2,10 @@
!!! Warning

GraphQL support in Starlette is **deprecated** as of version 0.15 and will
be removed in a future release. Please consider using a third-party library
to provide GraphQL support. This is usually done by mounting a GraphQL ASGI
application. See [#619](https://github.com/encode/starlette/issues/619).
be removed in a future release. It is also incompatible with Python 3.10+.
Please consider using a third-party library to provide GraphQL support. This
is usually done by mounting a GraphQL ASGI application.
See [#619](https://github.com/encode/starlette/issues/619).
Some example libraries are:

* [Ariadne](https://ariadnegraphql.org/docs/asgi)
Expand Down
2 changes: 1 addition & 1 deletion requirements.txt
@@ -1,5 +1,5 @@
# Optionals
graphene
graphene; python_version<'3.10'
itsdangerous
jinja2
python-multipart
Expand Down
5 changes: 5 additions & 0 deletions setup.cfg
Expand Up @@ -32,3 +32,8 @@ filterwarnings=

[coverage:run]
source_pkgs = starlette, tests
# GraphQLApp incompatible with and untested on Python 3.10. It's deprecated, let's just ignore
# coverage for it until it's gone.
omit =
starlette/graphql.py
tests/test_graphql.py
3 changes: 2 additions & 1 deletion setup.py
Expand Up @@ -40,7 +40,7 @@ def get_long_description():
install_requires=["anyio>=3.0.0,<4"],
extras_require={
"full": [
"graphene",
"graphene; python_version<'3.10'",
"itsdangerous",
"jinja2",
"python-multipart",
Expand All @@ -60,6 +60,7 @@ def get_long_description():
"Programming Language :: Python :: 3.7",
"Programming Language :: Python :: 3.8",
"Programming Language :: Python :: 3.9",
"Programming Language :: Python :: 3.10",
],
zip_safe=False,
)
4 changes: 4 additions & 0 deletions tests/conftest.py
@@ -1,7 +1,11 @@
import sys

import pytest

from starlette.testclient import TestClient

collect_ignore = ["test_graphql.py"] if sys.version_info >= (3, 10) else []


@pytest.fixture(
params=[
Expand Down

0 comments on commit ab0fff9

Please sign in to comment.