reset the __eq__ and __hash__ of HTTPConnection to allow WebSocke…

…ts to be added to … (#1039)

starlette/requests.py

@@ -74,6 +74,12 @@ def __iter__(self) -> typing.Iterator[str]:
     def __len__(self) -> int:
         return len(self.scope)
 
+    # Don't use the `abc.Mapping.__eq__` implementation.
+    # Connection instances should never be considered equal
+    # unless `self is other`.
+    __eq__ = object.__eq__
+    __hash__ = object.__hash__
+
     @property
     def app(self) -> typing.Any:
         return self.scope["app"]

tests/test_websockets.py

@@ -368,3 +368,13 @@ async def mock_send(message):
     assert websocket["type"] == "websocket"
     assert dict(websocket) == {"type": "websocket", "path": "/abc/", "headers": []}
     assert len(websocket) == 3
+
+    # check __eq__ and __hash__
+    assert websocket != WebSocket(
+        {"type": "websocket", "path": "/abc/", "headers": []},
+        receive=mock_receive,
+        send=mock_send,
+    )
+    assert websocket == websocket
+    assert websocket in {websocket}
+    assert {websocket} == {websocket}