Fix staticfiles 404 errors (#1005)

encode · Jul 20, 2020 · 681450d · 681450d
1 parent 6aa7d9e
commit 681450d
Showing 1 changed file with 3 additions and 5 deletions.
diff --git a/starlette/staticfiles.py b/starlette/staticfiles.py
@@ -140,11 +140,9 @@ async def lookup_path(
         self, path: str
     ) -> typing.Tuple[str, typing.Optional[os.stat_result]]:
         for directory in self.all_directories:
-            full_path = os.path.join(directory, path)
-            if (
-                os.path.commonprefix([os.path.realpath(full_path), directory])
-                != directory
-            ):
+            full_path = os.path.realpath(os.path.join(directory, path))
+            directory = os.path.realpath(directory)
+            if os.path.commonprefix([full_path, directory]) != directory:
                 # Don't allow misbehaving clients to break out of the static files directory.
                 continue
             try: