Return raw_path as byte string

According to ASGI spec [0], connection scope's `raw_path` should be a byte string. [0] https://asgi.readthedocs.io/en/latest/specs/www.html#connection-scope
encode · Jan 30, 2020 · 39f448d · 39f448d
1 parent 93c4249
commit 39f448d
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/starlette/testclient.py b/starlette/testclient.py
@@ -134,7 +134,7 @@ def send(
             scope = {
                 "type": "websocket",
                 "path": unquote(path),
-                "raw_path": path,
+                "raw_path": path.encode(),
                 "root_path": self.root_path,
                 "scheme": scheme,
                 "query_string": query.encode(),
@@ -151,7 +151,7 @@ def send(
             "http_version": "1.1",
             "method": request.method,
             "path": unquote(path),
-            "raw_path": path,
+            "raw_path": path.encode(),
             "root_path": self.root_path,
             "scheme": scheme,
             "query_string": query.encode(),

diff --git a/tests/test_requests.py b/tests/test_requests.py
@@ -188,7 +188,7 @@ async def app(scope, receive, send):
 
     client = TestClient(app)
     response = client.get("/he%2Fllo")
-    assert response.text == "/he/llo, /he%2Fllo"
+    assert response.text == "/he/llo, b'/he%2Fllo'"
 
 
 def test_request_without_setting_receive():