Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fast path returns for normalize_path cases #3189

Merged
merged 2 commits into from May 17, 2024
Merged

Fast path returns for normalize_path cases #3189

merged 2 commits into from May 17, 2024

Conversation

tomchristie
Copy link
Member

Return early for cases where there are no . or .. components in the path.

@tomchristie tomchristie added the perf Issues relating to performance label May 3, 2024
@zanieb
Copy link
Contributor

zanieb commented May 3, 2024 •
edited

Did you do any microbenchmarks? / is this motivated by a particular case?

@tomchristie
Copy link
Member Author

@zanieb good question.

@karpetrosyan
Copy link
Member

It's a very small change, I think we can merge this without any microbenchmarks.

@tomchristie
Copy link
Member Author

Okay, let's do that then.
It is still a good question. ☺️

@tomchristie tomchristie merged commit 37593c1 into master May 17, 2024
5 checks passed
@tomchristie tomchristie deleted the fast-returns-for-normalise-path-cases branch May 17, 2024 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zanieb zanieb zanieb approved these changes

Assignees
No one assigned
Labels
perf Issues relating to performance
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@tomchristie @zanieb @karpetrosyan