-
-
Notifications
You must be signed in to change notification settings - Fork 805
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tests: fix win32 #3172
Open
trim21
wants to merge
18
commits into
encode:master
Choose a base branch
from
trim21:testing-on-win32
base: master
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
tests: fix win32 #3172
Changes from 5 commits
Commits
Show all changes
18 commits
Select commit
Hold shift + click to select a range
2f7c3e0
fix test on win32
trim21 c8ac263
set default shell
trim21 2a088f6
fix ci
trim21 5245281
Merge branch 'master' into testing-on-win32
trim21 6d8d209
fix test
trim21 d339b4d
fix
trim21 8974fec
fix tempfile
trim21 70b292a
fix
trim21 131d16e
fix
trim21 31bef46
update
trim21 3794723
fix
trim21 ff66c06
comment
trim21 6743d78
trigger ci
trim21 dd48883
fix
trim21 5d39f62
fix ruff
trim21 482e7ac
fix
trim21 780cd99
fix test
trim21 583c786
Merge branch 'master' into testing-on-win32
trim21 File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -7,13 +7,18 @@ on: | |
pull_request: | ||
branches: ["master"] | ||
|
||
defaults: | ||
run: | ||
shell: bash | ||
|
||
jobs: | ||
tests: | ||
name: "Python ${{ matrix.python-version }}" | ||
runs-on: "ubuntu-latest" | ||
name: "Python ${{ matrix.python-version }} (${{ matrix.os }})" | ||
runs-on: "${{ matrix.os }}-latest" | ||
|
||
strategy: | ||
matrix: | ||
os: ["ubuntu", "windows"] | ||
python-version: ["3.8", "3.9", "3.10", "3.11", "3.12"] | ||
|
||
steps: | ||
|
@@ -32,3 +37,4 @@ jobs: | |
run: "scripts/test" | ||
- name: "Enforce coverage" | ||
run: "scripts/coverage" | ||
if: "matrix.os == 'ubuntu'" | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. We probably don't need this conditional once we've fixed up all the tests to pass okay on windows, right? |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure - I'm pleased to see us fix the test cases up for supporting windows, tho do we want to double the time our test runs take to complete?