Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix broken links in docs/contributing.md and CHANGELOG.md #3124

Merged
merged 2 commits into from Feb 29, 2024

Conversation

nick2i
Copy link
Contributor

@nick2i nick2i commented Feb 28, 2024

Summary

Similarly to #3123, some links to the /advanced/ section of the docs were out of date.
There is also one instance of link text changing from Writing custom transports -> Custom transports to match the section header.

There is an outstanding broken link in README.md that I wasn't sure about, maybe it should point to https://www.python-httpx.org/advanced/transports/#wsgi-transport?

[. . .] directly to [WSGI applications](https://www.python-httpx.org/advanced/#calling-into-python-web-apps) or [. . .]

Checklist

  • I understand that this PR may be closed in case there was no previous discussion. (This doesn't apply to typos!)
  • I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change.
  • I've updated the documentation accordingly.

Copy link
Member

@tomchristie tomchristie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! ☺️

@tomchristie tomchristie merged commit 4941b40 into encode:master Feb 29, 2024
5 checks passed
shepilov-vladislav pushed a commit to shepilov-vladislav/httpx that referenced this pull request Mar 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants