Make HttpStatusError and RequestError pickleable #3108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hoodmane
force-pushed
the
pickle-status-error
branch
3 times, most recently
from
0eef52c
to
5f81a85
Compare
If an error has keyword-only arguments, it needs this extra `__reduce__` method to ensure that unpickling doesn't raise `TypeError: missing (n) required keyword-only argument(s)`
hoodmane
force-pushed
the
pickle-status-error
branch
from
5f81a85
to
a3c0cb3
Compare
tomchristie
reviewed
Feb 23, 2024
Comment on lines
+74
to
+80
| def __reduce__( | ||
| self, | ||
| ) -> typing.Tuple[ | ||
| typing.Callable[..., Exception], typing.Tuple[typing.Any], dict[str, typing.Any] | ||
| ]: | ||
| return (Exception.__new__, (type(self),) + self.args, self.__dict__) | ||
|
|
There was a problem hiding this comment.
Are we able to be consistent with how pickle is supported on Request/Response here?
There was a problem hiding this comment.
All of the key word only arguments of Request have default values so that's why it's pickleable. Our choices here are:
- Give all kwonly arguments defaults. Classes where all kwonly arguments have defaults mostly have the correct pickle behavior without any special support.
- Do something like what I have here.
As an aside, this is a bit of a Python wart, ideally simple classes with required kwonly constructor args should be pickleable out of the box. I wonder if there is any discussion on discuss.python.org about it...
There was a problem hiding this comment.
Okay sure thing.
Thanks for the fix.
|
Worth adding a |
|
Okay updated changelog. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If an error has keyword-only arguments, it needs this extra
__reduce__method to ensure that unpickling doesn't raiseTypeError: missing (n) required keyword-only argument(s).Checklist