Add httpx.Mounts transport class.
#3070
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
httpx/_transports/mounts.py
Outdated
| return True | ||
|
|
||
| @property | ||
| def priority(self) -> typing.Tuple[int, int, int]: |
There was a problem hiding this comment.
Suggested change
| def priority(self) -> typing.Tuple[int, int, int]: | |
| def priority(self) -> tuple[int, int, int]: |
Now we support this :)
There was a problem hiding this comment.
Do we need CI check for this? Check out https://github.com/frostming/fix-future-annotations
tomchristie
changed the title
Mounts transport class.httpx.Mounts transport class.
T-256
reviewed
Jan 25, 2024
| pass | ||
|
|
||
|
|
||
| class URLPattern: |
There was a problem hiding this comment.
why duplicating it from httpx._utils?
There was a problem hiding this comment.
Well caught... because this pull request will also include removing mounts=... from the client, but I haven't gotten to that part yet.
It'll make more sense for all the implementation to be together in this module once the functionality is fully encompassed by httpx.Mounts().
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Discussed in #947 (comment)
This PR adds the
MountsandAsyncMountstransport classes.Currently in draft... switch
mounts=...out of theClientclass directly.Here's the synopsis...
We currently have
mounts=...behaviour backed directly into the client, like so...However it'd be neater to keep that complexity encapsulated within a transport class that supports routing, so...
At this point in time the pull request replicates the
mounts=...functionality in a transport class, but doesn't yet remove it from the client. A follow-up would deal with removing it.