Reorganise tests in 'test_url.py' #2981
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I would like to deal with #2883.
In order to tackle this comprehensively I'm suggesting we start by tidying up our existing URL test cases.
There are two parts to this:
models/test_url.py
- The current ordering of the tests isn't coherent.test_urlparse.py
, moving test cases intomodels/test_url.py
- All the test cases there are now properly against the publichttpx.URL()
interface, tackled previously as part of the Refactor test cases that import from private namespace.聽#2492.This pull request deals with the first of these two bullet-points.
I'll follow up with the second part once this is in.
Here's the explanation of the proposed change (assuming I've got it correct 馃槄)...
The ordering for the test cases here is...
httpx.URL
.httpx.QueryParams
.httpx.URL.join()
.httpx.URL.copy_with()
.httpx.URL.copy_<...>.params()
methods.