Limit which text codecs are supported. #2896
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
j178
reviewed
Oct 19, 2023
tomchristie
commented
Nov 3, 2023
Comment on lines
+34
to
+35
| # We're referencing them with the canonical name as used by the Python codecs. | ||
| # The alias given in the chromium source is included as a comment for comparison. |
There was a problem hiding this comment.
We're referencing these character sets with the canonical name as used by the Python codecs.
- Will the canonical name for the codec be consistent across different Python implementations?
- Should we instead just be including all the possible aliases explicitly?
- What set of aliases does chromium support for these charset names?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2892.
Constrains which text codecs are supported when accessing
response.text.(Uses the set currently supported by the Chromium browser.)
Initially prompted by behaviour in #2881 where a non-text codec "base64" was being loaded and causing an exception. The behaviour after this PR would be to fallback to
utf-8in that case, with safe character replacement. The result would be the base64 encoded string being returned as a string.