Use ruff instead of flake8, autoflake and isort #2648
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kludex
force-pushed
the
refactor/use-ruff
branch
from
4a7e81a
to
7e5f310
Compare
tomchristie
reviewed
Apr 5, 2023
tomchristie
reviewed
Apr 5, 2023
tomchristie
reviewed
Apr 5, 2023
| @@ -84,7 +84,7 @@ async def test_access_content_stream_response(server): | |||
|
|
|||
| assert response.status_code == 200 | |||
| with pytest.raises(httpx.ResponseNotRead): | |||
| response.content | |||
| response.content # noqa: B018 | |||
There was a problem hiding this comment.
How can I track down what a B018 is?
There was a problem hiding this comment.
It's on the rules page: https://beta.ruff.rs/docs/rules/#flake8-bugbear-b
Should I add a comment here or ignore it globally?
Kludex
commented
Apr 5, 2023
| @@ -84,7 +84,7 @@ async def test_access_content_stream_response(server): | |||
|
|
|||
| assert response.status_code == 200 | |||
| with pytest.raises(httpx.ResponseNotRead): | |||
| response.content | |||
| response.content # noqa: B018 | |||
There was a problem hiding this comment.
It's on the rules page: https://beta.ruff.rs/docs/rules/#flake8-bugbear-b
Should I add a comment here or ignore it globally?
tomchristie
approved these changes
Apr 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref.: #2607