Add support for streaming in ASGIDispatch #2588
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
florimondmanca
force-pushed
the
bug/async-early-stream-break
branch
from
02a5ed7
to
8afd29a
Compare
florimondmanca
force-pushed
the
fm/asgi-streaming
branch
from
0da3808
to
f9dfd37
Compare
tomchristie
reviewed
Feb 15, 2023
| @@ -35,12 +42,19 @@ def create_event() -> "Event": | |||
| return asyncio.Event() | |||
There was a problem hiding this comment.
It looks to me like we can drop this create_event() function and the preceding if typing.TYPE_CHECKING block?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs #2186
Note that this is based on #2587