Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop private import of 'format_form_param' from tests #2500

Merged
merged 3 commits into from Dec 12, 2022
Merged

Drop private import of 'format_form_param' from tests #2500

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ca28329
Drop private import of 'format_form_param' from tests
tomchristie Dec 12, 2022
4456cd0
Drop unused code path
tomchristie Dec 12, 2022
b0bed81
Merge branch 'master' into drop-private-format-form-params-import
tomchristie Dec 12, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
29 changes: 20 additions & 9 deletions tests/test_multipart.py
View file
Open in desktop
Expand Up @@ -8,7 +8,6 @@

import httpx
from httpx._content import encode_request
from httpx._utils import format_form_param


def echo_request_content(request: httpx.Request) -> httpx.Response:
Expand Down Expand Up @@ -436,17 +435,29 @@ def test_multipart_rewinds_files():

class TestHeaderParamHTML5Formatting:
def test_unicode(self):
param = format_form_param("filename", "n\u00e4me")
assert param == b'filename="n\xc3\xa4me"'
filename = "n\u00e4me"
expected = b'filename="n\xc3\xa4me"'
files = {"upload": (filename, b"<file content>")}
request = httpx.Request("GET", "https://www.example.com", files=files)
assert expected in request.read()

def test_ascii(self):
param = format_form_param("filename", b"name")
assert param == b'filename="name"'
filename = "name"
expected = b'filename="name"'
files = {"upload": (filename, b"<file content>")}
request = httpx.Request("GET", "https://www.example.com", files=files)
assert expected in request.read()

def test_unicode_escape(self):
param = format_form_param("filename", "hello\\world\u0022")
assert param == b'filename="hello\\\\world%22"'
filename = "hello\\world\u0022"
expected = b'filename="hello\\\\world%22"'
files = {"upload": (filename, b"<file content>")}
request = httpx.Request("GET", "https://www.example.com", files=files)
assert expected in request.read()

def test_unicode_with_control_character(self):
param = format_form_param("filename", "hello\x1A\x1B\x1C")
assert param == b'filename="hello%1A\x1B%1C"'
filename = "hello\x1A\x1B\x1C"
expected = b'filename="hello%1A\x1B%1C"'
files = {"upload": (filename, b"<file content>")}
request = httpx.Request("GET", "https://www.example.com", files=files)
assert expected in request.read()