-
-
Notifications
You must be signed in to change notification settings - Fork 808
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add fake setup.py #2351
Add fake setup.py #2351
Conversation
This is the same solution as Edit: Probably good to link the underlying problem. https://github.com/orgs/community/discussions/6456 |
Flask does this: https://github.com/pallets/flask/blob/main/setup.py#L3-L16 |
That’s a raging GitHub limitation. I’d be okay with this PR; happier to use newest standards than stick to oldest because GH is lagging behind. The sad part is we’d have to do this and duplicate dependency declaration every project. So I’m on the fence… |
How we decide here? |
I've created #2352 as an alternative to this PR. |
"Flask does this" is a pretty good argument. 😅
Indeed. I'm not wild about it either, but the pallets team have this on all their repos. Probably an okay solution for now. |
Since that's the case. Shall we choose this PR? |
I'll merge this tonight if no objections are made. 🙏 Thanks @michaeloliverx 🙏 |
This is quite sad.
@michaeloliverx brought this to our attention on: 45b7cfa#commitcomment-82042745.
The
Used by
section on the project's profile disappeared after we removed thesetup.py
. We can either accept this PR or revert #2334, to have it back,I'll let you folks decide @florimondmanca @tomchristie 🙏
I'll update the Starlette and Uvicorn according to what is decided here.
Closes #2352