Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin markdown==3.3.7 to prevent mkautodoc loading failure #2313

Merged
merged 1 commit into from
Jul 19, 2022

Conversation

florimondmanca
Copy link
Member

This PR gets CI back in shape as there is an issue with mkautodoc when the latest Markdown version is installed:

Python 3.10.0 (default, Nov 28 2021, 23:05:33) [GCC 9.3.0] on linux
Type "help", "copyright", "credits" or "license" for more information.
>>> import mkautodoc
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "/home/florimond/dev/fairness/httpx/venv/lib/python3.10/site-packages/mkautodoc/__init__.py", line 1, in <module>
    from .extension import MKAutoDocExtension, makeExtension
  File "/home/florimond/dev/fairness/httpx/venv/lib/python3.10/site-packages/mkautodoc/extension.py", line 4, in <module>
    from markdown.util import etree
ImportError: cannot import name 'etree' from 'markdown.util' (/home/florimond/dev/fairness/httpx/venv/lib/python3.10/site-packages/markdown/util.py)
>>> 

https://python-markdown.github.io/change_log/release-3.4/

Previously deprecated objects have been removed

Deprecated Object Replacement Object
markdown.util.etree xml.etree.ElementTree

@Kludex
Copy link
Sponsor Member

Kludex commented Jul 19, 2022

Ah, that was it. 😅

@florimondmanca
Copy link
Member Author

florimondmanca commented Jul 19, 2022

@tomchristie I opened tomchristie/mkautodoc#33 to fix the underlying issue.

(Would we want to move this project to Encode so anyone in encode/maintainers can help maintain it?)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants