-
-
Notifications
You must be signed in to change notification settings - Fork 807
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Apply PEP-621 #2145
Apply PEP-621 #2145
Conversation
Oh... |
Discussion on dropping 3.6 support #2136 |
What do we think about this bit at the top of the setuptools docs page…?
Presumably the idea if we go with this, we'd switch all Encode projects over as well eventually. Is now a good time? Also, what does this get us compared to the current |
Maybe not. Let's wait for others to test this first 😅 👍
One less file (setup.py), and compliance with the mentioned PEP. |
For another point of comparison, I played with |
Co-authored-by: Florimond Manca <florimond.manca@protonmail.com>
Co-authored-by: Florimond Manca <florimond.manca@protonmail.com>
Co-authored-by: Florimond Manca <florimond.manca@protonmail.com>
Thanks for the review @florimondmanca 🙇 I've updated the PR, sync with the changes that happened on |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Personally happy with this. Still happy to read other people's opinion.
My last question would be -- have we checked py.typed
is present in the resulting sdist
? (If not, releasing would break type hints.)
It adds correctly the I've added the |
Let's wait for @tomchristie 's opinion here? |
@@ -0,0 +1,61 @@ | |||
[build-system] | |||
requires = ["setuptools", "setuptools-scm"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should add a minimal version of setuptools as a build requirement to ensure that a compatible version of setuptools is installed.
requires = ["setuptools", "setuptools-scm"] | |
requires = ["setuptools>=61", "setuptools-scm"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agreed
|
This was brought on encode/starlette#1359.
setuptools released 0.61.0 yesterday, and brought to light the PEP-621 which makes this PR possible. Most of the PR was inspired on this page: https://setuptools.pypa.io/en/latest/userguide/pyproject_config.html
Notes:
I'll continue later on. I need to check if everything is included on the metadata files.How to test?
./scripts/build
to see that wheel andtar.gz
are generatedpython -m pip install -e .
for editable installs