Map UnsupportedProtocol to InvalidURL #1904
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aminalaee
commented
Oct 20, 2021
| httpx.get("https://example<>.com") | ||
|
|
||
| with pytest.raises(httpx.InvalidURL): | ||
| httpx.get("https://🦋") |
There was a problem hiding this comment.
Not really sure if this is the best place for tests.
…aminalaee/httpx into map-unsupported-protocol-to-invalid-url
aminalaee
commented
Oct 20, 2021
| @@ -66,8 +64,3 @@ def test_stream(server): | |||
| assert response.reason_phrase == "OK" | |||
| assert response.text == "Hello, world!" | |||
| assert response.http_version == "HTTP/1.1" | |||
|
|
|||
|
|
|||
| def test_get_invalid_url(): | |||
|
I think... we probably need to dig into expected behaviours a little more here, before pushing on with changes. I'm going to discuss this against this issue itself... |
|
@tomchristie Agreed. This will basically omit UnsupportedProtocol. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs #1832 .
Updates mapping to raise InvalidURL for UnsupportedProtocol exceptions from httpcore.
Not sure if this is the best approach.
Any feedback is appreciated.