Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop private import of 'format_form_param' from tests #2500

Merged
merged 3 commits into from Dec 12, 2022
Merged

Drop private import of 'format_form_param' from tests #2500

merged 3 commits into from Dec 12, 2022

Conversation

tomchristie
Copy link
Member

Refs #2492

@zanieb
Copy link
Contributor

zanieb commented Dec 12, 2022

Hm, how did this reduce coverage?

@tomchristie
Copy link
Member Author

tomchristie commented Dec 12, 2022 •
edited

Hm, how did this reduce coverage

Ah, interesting.

Change exposes an otherwise unused code-path, that's only needed against our previous private-import test...

Fixed with commit 4456cd0

@tomchristie tomchristie merged commit b82fbe2 into master Dec 12, 2022
@tomchristie tomchristie deleted the drop-private-format-form-params-import branch December 12, 2022 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zanieb zanieb zanieb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@tomchristie @zanieb