Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Breaking drop of URL.raw in patch release 0.23.1 #2462

Closed
developerDemetri opened this issue Nov 22, 2022 · 4 comments · Fixed by #2481
Closed

Breaking drop of URL.raw in patch release 0.23.1 #2462

developerDemetri opened this issue Nov 22, 2022 · 4 comments · Fixed by #2481

Comments

@developerDemetri
Copy link
Contributor

The patch release 0.23.1 included a breaking change in #2241

The justification seems to be that "we don't use it", but url.raw is a public property used by other libraries including ddtrace 0.x versions: https://github.com/DataDog/dd-trace-py/blob/v0.61.3/ddtrace/contrib/httpx/patch.py#L41

Can this breaking change be reverted and maybe soft-deprecated? @tomchristie @michaeloliverx
@developerDemetri
Copy link
Contributor Author

developerDemetri commented Nov 22, 2022 •
edited

Looks like this has been raised in #2457 but it seems like reverting here would be more ideal (and safer) than hoping other dependencies all refactor their usage?

@tomchristie
Copy link
Member

@developerDemetri - Would it help you folks if we released a patch version which included url.raw returning a NamedTuple? That wouldn't be a full rollback or adding httpx.RawURL back to the API, but we could do that quickly and easily, and it would resolve the specific case you're pointing to.

@gleberdiniz gleberdiniz mentioned this issue Nov 25, 2022
Closed
@developerDemetri
Copy link
Contributor Author

@developerDemetri - Would it help you folks if we released a patch version which included url.raw returning a NamedTuple? That wouldn't be a full rollback or adding httpx.RawURL back to the API, but we could do that quickly and easily, and it would resolve the specific case you're pointing to.

Yup, that should help for our use case and anyone else relying on url.raw

danielballan added a commit to danielballan/tiled that referenced this issue Nov 28, 2022
@danielballan
Ban httpx 0.23.1
f234f62 
This made a backward-incompatible change, removing the attribute
URL.raw. It looks like the maintainers plan to reinstate it as a
namedtuple in a coming patch release.

encode/httpx#2462
danielballan added a commit to danielballan/tiled that referenced this issue Nov 28, 2022
@danielballan
Ban httpx 0.23.1
4342abd 
This made a backward-incompatible change, removing the attribute
URL.raw. It looks like the maintainers plan to reinstate it as a
namedtuple in a coming patch release.

encode/httpx#2462
@danielballan danielballan mentioned this issue Nov 28, 2022
Merged
@developerDemetri developerDemetri mentioned this issue Nov 30, 2022
Merged
@developerDemetri
Copy link
Contributor Author

@developerDemetri - Would it help you folks if we released a patch version which included url.raw returning a NamedTuple? That wouldn't be a full rollback or adding httpx.RawURL back to the API, but we could do that quickly and easily, and it would resolve the specific case you're pointing to.

Yup, that should help for our use case and anyone else relying on url.raw

@tomchristie I took a stab at this in #2481

archlinux-github pushed a commit to archlinux/svntogit-community that referenced this issue Jan 5, 2023
upgpkg: python-httpx 0.23.3-1
568efd9 
Both 0.23.1 [1] and 0.23.2 [2] come with backward-incompatible changes,
both of which are (partially) reverted later. Pushing to
[community-testing] first as I'm scared.

[1] encode/httpx#2462
[2] encode/httpx#2538

git-svn-id: file:///srv/repos/svn-community/svn@1378295 9fca08f4-af9d-4005-b8df-a31f2cc04f65
archlinux-github pushed a commit to archlinux/svntogit-community that referenced this issue Jan 5, 2023
upgpkg: python-httpx 0.23.3-1
9a690e8 
Both 0.23.1 [1] and 0.23.2 [2] come with backward-incompatible changes,
both of which are (partially) reverted later. Pushing to
[community-testing] first as I'm scared.

[1] encode/httpx#2462
[2] encode/httpx#2538


git-svn-id: file:///srv/repos/svn-community/svn@1378295 9fca08f4-af9d-4005-b8df-a31f2cc04f65
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add back in URL.raw with NamedTuple developerDemetri/httpx
2 participants
@tomchristie @developerDemetri