Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Close responses when on cancellations occur during reading. #2156

Merged
merged 4 commits into from Mar 31, 2022
Merged

Close responses when on cancellations occur during reading. #2156

merged 4 commits into from Mar 31, 2022

Conversation

tomchristie
Copy link
Member

@tomchristie tomchristie commented Mar 31, 2022 •
edited

Based on #2148 but adding a test case which doesn't introduce sleep into our test suite.

  • Add failing test case.
  • Fix test case by switching to except BaseException: ... close ... raise throughout.

Closes #2139

@tomchristie tomchristie mentioned this pull request Mar 31, 2022
Closed
@tomchristie tomchristie requested a review from a team March 31, 2022 11:34
@tomchristie tomchristie merged commit 3350d7e into master Mar 31, 2022
@tomchristie tomchristie deleted the close-stream-on-base-exceptions branch March 31, 2022 12:41
@tomchristie tomchristie mentioned this pull request May 9, 2022
Merged
@rikroe rikroe mentioned this pull request May 19, 2022
Closed
@bdraco bdraco mentioned this pull request May 27, 2022
Merged
22 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@florimondmanca florimondmanca florimondmanca approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@tomchristie @florimondmanca