Skip to content

Commit

Permalink
fix test on win32
Browse files Browse the repository at this point in the history
  • Loading branch information
trim21 committed Apr 17, 2024
1 parent 4b85e6c commit 2f7c3e0
Show file tree
Hide file tree
Showing 5 changed files with 17 additions and 3 deletions.
5 changes: 3 additions & 2 deletions .github/workflows/test-suite.yml
Expand Up @@ -9,11 +9,12 @@ on:

jobs:
tests:
name: "Python ${{ matrix.python-version }}"
runs-on: "ubuntu-latest"
name: "Python ${{ matrix.python-version }} (${{ matrix.os }})"
runs-on: "${{ matrix.os }}-latest"

strategy:
matrix:
os: ["ubuntu", "windows"]
python-version: ["3.8", "3.9", "3.10", "3.11", "3.12"]

steps:
Expand Down
5 changes: 4 additions & 1 deletion tests/client/test_async_client.py
@@ -1,5 +1,6 @@
from __future__ import annotations

import sys
import typing
from datetime import timedelta

Expand All @@ -18,7 +19,9 @@ async def test_get(server):
assert response.http_version == "HTTP/1.1"
assert response.headers
assert repr(response) == "<Response [200 OK]>"
assert response.elapsed > timedelta(seconds=0)
if sys.platform != "win32":
# flaky on windows
assert response.elapsed > timedelta(seconds=0)


@pytest.mark.parametrize(
Expand Down
4 changes: 4 additions & 0 deletions tests/test_multipart.py
@@ -1,6 +1,7 @@
from __future__ import annotations

import io
import sys
import tempfile
import typing

Expand Down Expand Up @@ -371,6 +372,9 @@ def test_multipart_encode_files_raises_exception_with_StringIO_content() -> None
httpx.Request("POST", url, data={}, files=files) # type: ignore


@pytest.mark.skipif(
sys.platform == "win32", reason="TemporaryFile on windows is binary mode"
)
def test_multipart_encode_files_raises_exception_with_text_mode_file() -> None:
url = "https://www.example.com"
with tempfile.TemporaryFile(mode="w") as upload:
Expand Down
4 changes: 4 additions & 0 deletions tests/test_timeouts.py
@@ -1,3 +1,5 @@
import sys

import pytest

import httpx
Expand All @@ -12,6 +14,7 @@ async def test_read_timeout(server):
await client.get(server.url.copy_with(path="/slow_response"))


@pytest.mark.skipif(sys.platform == "win32", reason="broken on windows")
@pytest.mark.anyio
async def test_write_timeout(server):
timeout = httpx.Timeout(None, write=1e-6)
Expand All @@ -33,6 +36,7 @@ async def test_connect_timeout(server):
await client.get("http://10.255.255.1/")


@pytest.mark.skipif(sys.platform == "win32", reason="broken on windows")
@pytest.mark.anyio
async def test_pool_timeout(server):
limits = httpx.Limits(max_connections=1)
Expand Down
2 changes: 2 additions & 0 deletions tests/test_utils.py
Expand Up @@ -2,6 +2,7 @@
import logging
import os
import random
import sys

import certifi
import pytest
Expand Down Expand Up @@ -122,6 +123,7 @@ def test_logging_redirect_chain(server, caplog):
]


@pytest.mark.skipif(sys.platform == "win32", reason="Path separator problem")
def test_logging_ssl(caplog):
caplog.set_level(logging.DEBUG)
with httpx.Client():
Expand Down

0 comments on commit 2f7c3e0

Please sign in to comment.