Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version 1.0 #809

Merged
merged 14 commits into from Oct 6, 2023
Merged

Version 1.0 #809

merged 14 commits into from Oct 6, 2023

Conversation

tomchristie
Copy link
Member

@tomchristie tomchristie commented Sep 19, 2023

Proposal for httpcore version 1.0.

Our API is already stable, and I don't think we've any blockers that ought to prevent us issuing a 1.0 release.

The one change that I am suggesting in this pull request is that we switch to a more minimal set of default dependancies, by making the async case fully optional. We've already done the work on making these packages not strictly required. This proposal builds on that work by no longer installing anyio/sniffio/trio by default.


TODO:

  • Update CHANGELOG.md

See also encode/httpx#947.

@karpetrosyan
Copy link
Member

Do we want #800 after this release?

@tomchristie
Copy link
Member Author

tomchristie commented Sep 19, 2023

Do we want #800 after this release?

Have followed up against that discussion.

@tomchristie tomchristie marked this pull request as ready for review September 25, 2023 12:59
@tomchristie tomchristie requested a review from a team September 25, 2023 12:59
Copy link
Member

@karpetrosyan karpetrosyan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can change the error message in https://github.com/encode/httpcore/pull/809/files#diff-5bb436aadeb1bfe2f41078fe8d1a4db589eb3405df644e07ce5e26c7749da824R40 to something like Running under trio requires the 'httpcore' to be installed with the 'trio' extra.  because when the user has trio installed, the current message doesn't make any sense.

@zanieb
Copy link
Contributor

zanieb commented Sep 26, 2023

because when the user has trio installed, the current message doesn't make any sense

Why would that error be displayed when trio is installed?

@karpetrosyan
Copy link
Member

because when the user has trio installed, the current message doesn't make any sense

Why would that error be displayed when trio is installed?

When the trio is installed but the sniffio isn't

See: https://github.com/encode/httpcore/pull/809/files#diff-5bb436aadeb1bfe2f41078fe8d1a4db589eb3405df644e07ce5e26c7749da824R20-R24

@tomchristie
Copy link
Member Author

We can change the error message

Resolved

pyproject.toml Outdated Show resolved Hide resolved
@tomchristie
Copy link
Member Author

I think we're good to go here... I'll plan on releasing this tomorrow.

@karpetrosyan
Copy link
Member

Do we want to include #799 to 1.0.0?

@tomchristie
Copy link
Member Author

Ok.

@tomchristie tomchristie merged commit 12834e3 into master Oct 6, 2023
5 checks passed
@tomchristie tomchristie deleted the version-1.0 branch October 6, 2023 11:21
@karpetrosyan
Copy link
Member

Release date 🥶

@tomchristie
Copy link
Member Author

Oops. (thanks)

@agronholm
Copy link
Contributor

On that note, how are you creating your GitHub releases? I don't see any automation.

@tomchristie
Copy link
Member Author

Copy the release notes. Yup some buttons do get pressed through the GitHub UI.
From that, the PyPI releases are automated from a GitHub action.

@agronholm
Copy link
Contributor

In case you're interested, here's how I handle things: https://github.com/agronholm/anyio/blob/master/.github/workflows/publish.yml
Pushing a tag makes the automation copy the release notes matching the tag, and make a GitHub release as well as publishing the sdist and wheels to PyPI.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants