Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add HTTP/2 "data_stream" extension #684

Closed
wants to merge 5 commits into from
Closed

Conversation

tomchristie
Copy link
Member

@tomchristie tomchristie commented May 15, 2023

Refs encode/httpx#1150

  • Initial implementation.
  • Does the stream interface here expose the correct API. (Eg. do we want read(max_bytes=...)?)
  • Add test case. (Currently failing coverage)
  • Add documentation.

@tomchristie tomchristie added the enhancement New feature or request label May 15, 2023
@tomchristie
Copy link
Member Author

I'm going to close this off for now...

If there's motivation from anyone to proceed with HTTP/2 bi-directional streams then we'd want:

  • To start with a design discussion.
  • A pull request that begins with a test case & docs.
  • This implementation is a good reference for a resolution, but we also need to not terminate the outgoing data stream when we send the request. We also probably want to avoid altering the _recieve_response_body method in order to support this niche use-case. We can instead have a bit more implementation detail inside the HTTP2DataStream class.

@tomchristie tomchristie deleted the http2-data-stream branch June 13, 2023 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant