preventing asyncio.CancelledError from disrupting the request handling without marking the connection as failed #578
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…g without marking the connection as failed
zanieb
reviewed
Sep 25, 2022
| if not isinstance(exc, ConnectionNotAvailable): | ||
| self._connect_failed = True | ||
|
|
||
| raise exc |
There was a problem hiding this comment.
I believe using raise exc will add extra frames to the traceback
Suggested change
| raise exc | |
| raise |
|
I believe this also addresses #564 |
Thank you, yes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
attempts to address the issue reported in encode/httpx#2139 (comment)
feel free to take over and make it a more complete patch, this is what I did locally and worked. just wanted to share the approach :)