Drop unused testing requirements #473
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See also this comment: #442 (comment) |
archlinux-github
pushed a commit
to archlinux/svntogit-community
that referenced
this pull request
Oct 29, 2022
* curio not needed after encode/httpcore#470 * hypercorn, pproxy, trustme, uvicorn not needed after encode/httpcore#473 git-svn-id: file:///srv/repos/svn-community/svn@1338525 9fca08f4-af9d-4005-b8df-a31f2cc04f65
archlinux-github
pushed a commit
to archlinux/svntogit-community
that referenced
this pull request
Oct 29, 2022
* curio not needed after encode/httpcore#470 * hypercorn, pproxy, trustme, uvicorn not needed after encode/httpcore#473 git-svn-id: file:///srv/repos/svn-community/svn@1338525 9fca08f4-af9d-4005-b8df-a31f2cc04f65
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have several test requirements that are actually no longer being used.
For context, this is a result of the drastic 0.14 re-working, which has made the package much more testable throughout.
We're generally testing against mocked streams, rather than against uvicorn/hypercorn. We have far better coverage now than we had before (100%, with only explicit exemptions.)
The integration testing we do have is currently using
pytest-httpbin. Personally I'd like to drop this too in favour of something more explicit, but that's a story for another day.