Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added pproxy test fixture, which allows to test requesting through socks proxy #196

Closed
wants to merge 1 commit into from

Conversation

cdeler
Copy link
Member

@cdeler cdeler commented Sep 25, 2020

As a part of encode/httpx#203 (draft pr is #188) I'd like to introduce the "socks" test fixture.

Using pproxy it starts a subprocess with socks4 and socks5 (with auth and without auth) proxies on localhost.

Also the PR contains some new types, required in the fixture

There is a problem: this server doesn't support socks4a proxy (may be it's not so important)

@cdeler cdeler requested review from a team and tomchristie September 25, 2020 13:05
@tomchristie
Copy link
Member

I don't think this is quite what I was expecting here.
A more minimal first step would be adding some pproxy tests cases for our existing regular HTTP/HTTPS proxy support.

@cdeler
Copy link
Member Author

cdeler commented Sep 28, 2020

@tomchristie

You are talking about proxy_server fixture, which is used by test_http_proxy and test_proxy_https_requests? (if so, I'm doing that)

@pytest.fixture()
def proxy_server(example_org_cert_path: str) -> typing.Iterator[URL]:

@cdeler
Copy link
Member Author

cdeler commented Sep 28, 2020

Closing this PR, replacing it by #199

@cdeler cdeler closed this Sep 28, 2020
@cdeler cdeler deleted the add-pproxy-test-fixture branch September 28, 2020 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants