Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable mypy option --strict #616

Merged
merged 1 commit into from Nov 21, 2022
Merged

Enable mypy option --strict #616

merged 1 commit into from Nov 21, 2022

Conversation

michaeloliverx
Copy link
Member

@michaeloliverx michaeloliverx commented Nov 21, 2022 •
edited

Closes: #514

@michaeloliverx michaeloliverx marked this pull request as ready for review November 21, 2022 12:20
tomchristie
tomchristie approved these changes Nov 21, 2022
View reviewed changes
Copy link
Member

@tomchristie tomchristie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nicely done @michaeloliverx!

@tomchristie tomchristie merged commit faa166c into encode:master Nov 21, 2022
@michaeloliverx michaeloliverx deleted the mypy-strict branch November 21, 2022 12:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomchristie tomchristie tomchristie approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Enable Mypy --strict internally
2 participants
@michaeloliverx @tomchristie