Enable mypy option --strict (#616)

setup.cfg

@@ -4,14 +4,9 @@ max-line-length = 120
 exclude = httpcore/_sync,tests/_sync
 
 [mypy]
-disallow_untyped_defs = True
+strict = True
 ignore_missing_imports = True
-no_implicit_optional = True
 show_error_codes = True
-warn_unused_ignores = True
-disallow_untyped_calls = True
-warn_return_any = True
-disallow_any_generics = True
 
 [mypy-tests.*]
 disallow_untyped_defs = False

tests/_async/test_connection.py

@@ -1,4 +1,4 @@
-from typing import Optional
+from typing import List, Optional
 
 import hpack
 import hyperframe.frame
@@ -124,9 +124,9 @@ async def test_request_to_incorrect_origin():
 
 
 class NeedsRetryBackend(AsyncMockBackend):
-    def __init__(self, *args, **kwargs) -> None:
+    def __init__(self, buffer: List[bytes], http2: bool = False) -> None:
         self._retry = 2
-        super().__init__(*args, **kwargs)
+        super().__init__(buffer, http2)
 
     async def connect_tcp(
         self,

tests/_async/test_connection_pool.py

@@ -4,6 +4,7 @@
 import trio as concurrency
 
 from httpcore import AsyncConnectionPool, ConnectError, PoolTimeout, UnsupportedProtocol
+from httpcore.backends.base import AsyncNetworkStream
 from httpcore.backends.mock import AsyncMockBackend
 
 
@@ -206,7 +207,7 @@ async def connect_tcp(
             port: int,
             timeout: Optional[float] = None,
             local_address: Optional[str] = None,
-        ):
+        ) -> AsyncNetworkStream:
             raise ConnectError("Could not connect")
 
     network_backend = FailedConnectBackend([])

tests/_sync/test_connection.py

@@ -1,4 +1,4 @@
-from typing import Optional
+from typing import List, Optional
 
 import hpack
 import hyperframe.frame
@@ -124,9 +124,9 @@ def test_request_to_incorrect_origin():
 
 
 class NeedsRetryBackend(MockBackend):
-    def __init__(self, *args, **kwargs) -> None:
+    def __init__(self, buffer: List[bytes], http2: bool = False) -> None:
         self._retry = 2
-        super().__init__(*args, **kwargs)
+        super().__init__(buffer, http2)
 
     def connect_tcp(
         self,

tests/_sync/test_connection_pool.py

@@ -4,6 +4,7 @@
 from tests import concurrency
 
 from httpcore import ConnectionPool, ConnectError, PoolTimeout, UnsupportedProtocol
+from httpcore.backends.base import NetworkStream
 from httpcore.backends.mock import MockBackend
 
 
@@ -206,7 +207,7 @@ def connect_tcp(
             port: int,
             timeout: Optional[float] = None,
             local_address: Optional[str] = None,
-        ):
+        ) -> NetworkStream:
             raise ConnectError("Could not connect")
 
     network_backend = FailedConnectBackend([])

tests/concurrency.py

@@ -31,7 +31,7 @@ def __exit__(
         for thread in self._threads:
             thread.join()
 
-    def start_soon(self, func: Callable[..., object], *args: Any):
+    def start_soon(self, func: Callable[..., object], *args: Any) -> None:
         thread = threading.Thread(target=func, args=args)
         self._threads.append(thread)