Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

configure strict pytest #442

Merged
merged 7 commits into from Feb 25, 2022
Merged

configure strict pytest #442

merged 7 commits into from Feb 25, 2022

Conversation

graingert
Copy link
Member

No description provided.

@graingert
Copy link
Member Author

a remake of #364

@tomchristie
Copy link
Member

Thanks @graingert!

@tomchristie
Copy link
Member

Hrrrmm... I think the warnings that I'm seeing here may be unclosed resources from the httpbin fixture that we're using, rather than actually from httpcore.

(I guess I could be wrong, but I'm seeing the proper socket closes when digging through the codebase.)

@tomchristie
Copy link
Member

Related - Ideally I'd rather replace our usage of a package based fixture here, with a plain ol' bit of socket code.
Just prefer a more slimline profile, rather than "neat bit of magic that spins up a whole httpbin server". I mean that was great to get going with, but I'd probably rather see a more down-to-basics, "a socket running in another thread that'll always just issue a 200 OK Hello World response".

@tomchristie tomchristie mentioned this pull request Jan 5, 2022
Merged
@stale
Copy link

stale bot commented Jan 22, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix This will not be worked on label Jan 22, 2022
@stale stale bot removed the wontfix This will not be worked on label Jan 22, 2022
@stale
Copy link

stale bot commented Feb 24, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

graingert
graingert commented Feb 24, 2022
View reviewed changes
setup.cfg Outdated Show resolved Hide resolved
graingert
graingert commented Feb 24, 2022
View reviewed changes
setup.cfg Outdated Show resolved Hide resolved
graingert
graingert commented Feb 24, 2022
View reviewed changes
setup.cfg Show resolved Hide resolved
graingert
graingert commented Feb 24, 2022
View reviewed changes
setup.cfg Show resolved Hide resolved
graingert
graingert commented Feb 24, 2022
View reviewed changes
setup.cfg
Comment on lines +28 to +29
ignore:ssl\.wrap_socket\(\) is deprecated, use SSLContext\.wrap_socket\(\):DeprecationWarning
ignore:ssl\.PROTOCOL_TLS is deprecated:DeprecationWarning
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/kevin1024/pytest-httpbin/pull/65/files

tomchristie
tomchristie approved these changes Feb 25, 2022
View reviewed changes
Copy link
Member

@tomchristie tomchristie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work on getting this to a resolution. Thanks!

@tomchristie tomchristie merged commit ebf0684 into encode:master Feb 25, 2022
@graingert graingert deleted the configure-strict-pytest branch February 25, 2022 12:24
archlinux-github pushed a commit to archlinux/svntogit-community that referenced this pull request May 18, 2022
upgpkg: python-httpcore 0.15.0-1
d6d8f8b 
* Add a link to upstream changelogs
* Update optdepends per namcap errors
* Drop the hack for pytest-cov, which is no longer used [1]
* Don't treat warnings as errors. That is introduced in [2] and causes
  issues like [3].

[1] encode/httpcore#218
[2] encode/httpcore#442
[3] encode/httpcore#548


git-svn-id: file:///srv/repos/svn-community/svn@1207757 9fca08f4-af9d-4005-b8df-a31f2cc04f65
archlinux-github pushed a commit to archlinux/svntogit-community that referenced this pull request May 18, 2022
upgpkg: python-httpcore 0.15.0-1
16ea5f7 
* Add a link to upstream changelogs
* Update optdepends per namcap errors
* Drop the hack for pytest-cov, which is no longer used [1]
* Don't treat warnings as errors. That is introduced in [2] and causes
  issues like [3].

[1] encode/httpcore#218
[2] encode/httpcore#442
[3] encode/httpcore#548

git-svn-id: file:///srv/repos/svn-community/svn@1207757 9fca08f4-af9d-4005-b8df-a31f2cc04f65
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomchristie tomchristie tomchristie approved these changes

@cdeler cdeler Awaiting requested review from cdeler

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@graingert @tomchristie