Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup #9393

Merged
merged 9 commits into from Apr 30, 2024
Merged

Cleanup #9393

merged 9 commits into from Apr 30, 2024

Conversation

peterthomassen
Copy link
Contributor

@peterthomassen peterthomassen commented Apr 26, 2024

As discussed, this removes support for Django < 4.2 and Python < 3.8.

Further changes:

  • code cleanup
  • docs updates
  • dependency bumps
  • remove Windows line endings

@peterthomassen peterthomassen marked this pull request as ready for review April 26, 2024 14:10
@peterthomassen peterthomassen marked this pull request as draft April 26, 2024 14:17
@peterthomassen peterthomassen marked this pull request as ready for review April 26, 2024 15:09
@peterthomassen peterthomassen force-pushed the 20240426_requirements branch 3 times, most recently from 8fb2a11 to 8030a12 Compare April 26, 2024 16:05
@peterthomassen peterthomassen changed the title 20240426 requirements Cleanup Apr 26, 2024
@peterthomassen
Copy link
Contributor Author

This has gotten a little larger due to the last commit, but don't get scared, it's just whitespace changes ;-) Ready for review.

@auvipy auvipy self-requested a review April 27, 2024 05:32
Copy link
Member

@tomchristie tomchristie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wonderful, thanks.

but don't get scared, it's just whitespace changes

In general let's try to isolate changes as much as possible. The easier it is to review, the less likely we are to have sneaky errors creeping in. 😅

@peterthomassen peterthomassen merged commit 9d4ed05 into master Apr 30, 2024
7 checks passed
@peterthomassen peterthomassen deleted the 20240426_requirements branch April 30, 2024 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants