xfail pytz test_invalid_inputs() on Django >= v5.0 #9344
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cclauss
changed the title
cclauss
changed the title
tomchristie
reviewed
Mar 28, 2024
tomchristie
reviewed
Mar 28, 2024
| @@ -672,6 +673,7 @@ def test_valid_inputs(self, *args): | |||
| assert self.field.run_validation(input_value) == expected_output, \ | |||
| 'input value: {}'.format(repr(input_value)) | |||
|
|
|||
| @pytest.mark.xfail(pytz and DJANGO_VERSION >= (5, 0), reason="Django v5 drops support for pytz") | |||
There was a problem hiding this comment.
This looks like it'll skip a whole load of tests regardless of if pytz is relevant to that particular test case or not.
Co-authored-by: Tom Christie <tom@tomchristie.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9342
+ @pytest.mark.xfail(pytz and DJANGO_VERSION >= (5, 0), reason="Django v5 drops support for pytz")Dj5 drops support for
pytzso skip this test on an invalid configuration.https://docs.djangoproject.com/en/5.0/releases/5.0/#features-removed-in-5-0