Fix ModelSerializer unique_together handling for field sources #7143
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updates ModelSerializer to check for serializer fields that map to the model field sources in the unique_together lists.
5 tasks
|
Bump on this. I am affected as well. When can we expect this to be merged and available in a release? |
|
@carltongibson are we planning another 3.11.x release, or straight to 3.12? |
|
I'm mentally lining up a 3.12, but we can call it 3.11.1 if you like. 😀 (There's quite a few schema changes that merit an announcement post I'd say so...) |
|
3.12 in this month would be really great :) |
|
@carltongibson Seems sensible yup - I'd happily carve out some of my working time for that. |
|
Fantastic stuff, @rpkilby! |
sigvef
pushed a commit
to sigvef/django-rest-framework
that referenced
this pull request
Dec 3, 2022
…e#7143) * Fix ModelSerializer unique_together field sources Updates ModelSerializer to check for serializer fields that map to the model field sources in the unique_together lists. * Ensure field name ordering consistency
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #7100 which was caused by related changes in #7086. Model serializers will now correctly use serializer field names that map to the field sources in
unique_together. If there are multiple fields that use the same source (seems unlikely but doesn't hurt to check?), then an error is raised instead. Note that the error is raised somewhat late during validation, but that's when the validators are generated. We could create/cache them on__init__(maybe cache fields and validators?), but that seems like a separate discussion.