Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correct allow_null behaviour when required=False #5888

Merged
merged 4 commits into from Mar 20, 2018
Merged

Correct allow_null behaviour when required=False #5888

merged 4 commits into from Mar 20, 2018

Commits on Mar 20, 2018

  1. Add test for allow_null + required=False 

    Ref encode#5708: allow_null should imply default=None, even for non-required fields.

flake8
    @carltongibson
    carltongibson committed Mar 20, 2018
    Configuration menu
    Copy the full SHA
    7bb92d3 View commit details
    Browse the repository at this point in the history

  2. Revert "Non-required fields with 'allow_null=True' should not imply a… 

    … default value (encode#5639)"

This reverts commit 905a557.

Closes encode#5708
    @carltongibson
    carltongibson committed Mar 20, 2018
    Configuration menu
    Copy the full SHA
    8d2ac40 View commit details
    Browse the repository at this point in the history

  3. Re-order allow_null and default in field docs 

    default is prior to allow_null. allow_null implies an outgoing default=None.
    @carltongibson
    carltongibson committed Mar 20, 2018
    Configuration menu
    Copy the full SHA
    e5034b2 View commit details
    Browse the repository at this point in the history

  4. Adjust allow_null note.

    @carltongibson
    carltongibson committed Mar 20, 2018
    Configuration menu
    Copy the full SHA
    758b797 View commit details
    Browse the repository at this point in the history