Correct allow_null behaviour when required=False #5888
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ref encode#5708: allow_null should imply default=None, even for non-required fields. flake8
… default value (encode#5639)" This reverts commit 905a557. Closes encode#5708
default is prior to allow_null. allow_null implies an outgoing default=None.
carltongibson
force-pushed
the
38/allow_null
branch
from
ee490aa
to
758b797
Compare
carltongibson
added a commit
that referenced
this pull request
Mar 20, 2018
carltongibson
added a commit
that referenced
this pull request
Mar 26, 2018
carltongibson
added a commit
that referenced
this pull request
Apr 3, 2018
pchiquet
pushed a commit
to pchiquet/django-rest-framework
that referenced
this pull request
Nov 17, 2020
* Revert "Non-required fields with 'allow_null=True' should not imply a default value (encode#5639)" This reverts commit 905a557. Closes encode#5708 * Add test for allow_null + required=False Ref encode#5708: allow_null should imply default=None, even for non-required fields. * Re-order allow_null and default in field docs default is prior to allow_null. allow_null implies an outgoing default=None. * Adjust allow_null note.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR reverts #5639. There
required=Falsewould override the implicit default coming fromallow_null, omitting the field from inclusion. This was incorrect, as reported in #5708.Closes #5708.
There's a slight BC issue here — although we're restoring an older behaviour. Overriding
datato remove the offending field ifNonewould serve as a fallback.TODO: