Use default argument of max() and change test name

encode · Aug 7, 2019 · 8e6ee98 · 8e6ee98
1 parent 957b39f
commit 8e6ee98
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/rest_framework/views.py b/rest_framework/views.py
@@ -363,7 +363,7 @@ def check_throttles(self, request):
                 if duration is not None
             ]
 
-            duration = max(durations) if durations else None
+            duration = max(durations, default=None)
             self.throttled(request, duration)
 
     def determine_version(self, request, *args, **kwargs):

diff --git a/tests/test_throttling.py b/tests/test_throttling.py
@@ -159,7 +159,7 @@ def test_request_throttling_multiple_throttles(self):
         assert response.status_code == 429
         assert int(response['retry-after']) == 58
 
-    def test_handle_negative_throttle_value(self):
+    def test_throttle_rate_change_negative(self):
         self.set_throttle_timer(MockView_DoubleThrottling, 0)
         request = self.factory.get('/')
         for dummy in range(24):